Skip to content

fix: Additional validations for OpenAI frontend LoRA paths - #8669

Merged
yinggeh merged 1 commit into
mainfrom
yinggeh/tri-740-additional-check-of-lora-npy-files-are-inside-model
Mar 2, 2026
Merged

fix: Additional validations for OpenAI frontend LoRA paths#8669
yinggeh merged 1 commit into
mainfrom
yinggeh/tri-740-additional-check-of-lora-npy-files-are-inside-model

Conversation

@yinggeh

@yinggeh yinggeh commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Additionally checks LoRA paths

  • must be an relative path
  • must be inside its model repository
  • must exist

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • fix

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@yinggeh
yinggeh requested review from pskiran1 and whoisj February 20, 2026 22:56
@yinggeh yinggeh self-assigned this Feb 20, 2026
@yinggeh yinggeh added the fix label Feb 20, 2026
@yinggeh
yinggeh merged commit df3dec3 into main Mar 2, 2026
3 checks passed
@yinggeh
yinggeh deleted the yinggeh/tri-740-additional-check-of-lora-npy-files-are-inside-model branch March 2, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants